8000 cp: gnu test case `i-2` compatibility for mv · Issue #6658 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cp: gnu test case i-2 compatibility for mv #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matrixhead opened this issue Aug 21, 2024 · 2 comments
Closed

cp: gnu test case i-2 compatibility for mv #6658

matrixhead opened this issue Aug 21, 2024 · 2 comments
Labels
U - cp

Comments

@matrixhead
Copy link
Contributor

This shared test case for cp and mv checks how they behave when the -i and -f flags are given. The test is failing because uu-cp's prompt message differs from GNU's cp.
for example

echo e > e
echo f > f
chmod 0 f
cp -if e f

this should give us a prompt saying.

cp: replace 'f', overriding mode 0000 (---------)?

but instead uu-cp would give us a normal prompt like this

cp: overwrite 'f'?
@matrixhead matrixhead mentioned this issue Aug 21, 2024
Closed
@sheikhevan
Copy link
sheikhevan commented Sep 2, 2024 •
edited
Loading

It seems like the current code is taking after freebsd coreutils, which only ask for overwrite.

andrewliebenow added a commit to andrewliebenow/coreutils that referenced this issue Sep 15, 2024
@andrewliebenow
cp: show mode if target does not have S_IWUSR
fe8463e 
If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
uutils#6658.
@andrewliebenow andrewliebenow mentioned this issue Sep 15, 2024
Closed
andrewliebenow added a commit to andrewliebenow/coreutils that referenced this issue Sep 15, 2024
@andrewliebenow
cp: show mode if target does not have S_IWUSR
e2a8e86 
If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
uutils#6658.
andrewliebenow added a commit to andrewliebenow/coreutils that referenced this issue Sep 16, 2024
@andrewliebenow
cp: show mode if target does not have S_IWUSR
3f3cbad 
If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
uutils#6658.
andrewliebenow added a commit to andrewliebenow/coreutils that referenced this issue Sep 16, 2024
@andrewliebenow
cp: show mode if target does not have S_IWUSR
983ee5a 
If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
uutils#6658.
andrewliebenow added a commit to andrewliebenow/coreutils that referenced this issue Sep 16, 2024
@andrewliebenow
cp: show mode if target does not have S_IWUSR
ab94098 
If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
uutils#6658.
sylvestre added a commit that referenced this issue Sep 18, 2024
@andrewliebenow @sylvestre
cp: show mode if target does not have S_IWUSR (PR #6696) (#6700)
b8150f5 
* cp: show mode if target does not have S_IWUSR

If the target exists, and does not have the user write bit (S_IWUSR)
set, additional information should be added to the overwrite
confirmation prompt.

This should get the "i-2" test to pass. See
#6658.

* cp: with -i, delete destination if needed

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@jfinkels
Copy link
Collaborator

The prompt messages seem fixed now, and the GNU test file tests/mv/i-2.sh is passing, so I'll close this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
U - cp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cakebaker @jfinkels @matrixhead @sheikhevan
0