8000 tests/common/util.rs panics with Broken pipe error on some targets when pipe_in() is used in tests · Issue #5338 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests/common/util.rs panics with Broken pipe error on some targets when pipe_in() is used in tests #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhitkoff opened this issue Sep 28, 2023 · 2 comments
Open

tests/common/util.rs panics with Broken pipe error on some targets when pipe_in() is used in tests #5338

zhitkoff opened this issue Sep 28, 2023 · 2 comments

Comments

@zhitkoff
Copy link
Contributor

coreutils/tests/common/util.rs

Lines 2014 to 2015 in aa0437c

.expect("Error joining with the piping stdin thread")
.unwrap();

This seems to be the culprit. Maybe add handling the errors with match/if let instead of expect().unwrap() ?
@tertsdiepraam
Copy link
Member

Hmm, what would we then do in the error branch? I guess we could ignore the error, but that shouldn't be necessary. Which targets are impacted by this?

@zhitkoff
Copy link
Contributor Author
zhitkoff commented Sep 30, 2023 •
edited
Loading

yes, specifically for broken pipe - ignore it. Panic on the other errors. Targets where it failed consistently are ubuntu-latest intel (i686, x84_64). All other targets did not fail on the same tests. The workaround is to use .ignore_stdin_write_error() of UCommand instances in tests that use .pipe_in() stdin feed, but it should not be required - it works without it on all other targets.

Example: https://github.com/uutils/coreutils/actions/runs/6342269393/job/17227755302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tertsdiepraam @zhitkoff
0