8000 `cp -dR --no-preserve=links d c` should have different inodes · Issue #5308 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cp -dR --no-preserve=links d c should have different inodes #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sylvestre opened this issue Sep 24, 2023 · 4 comments · Fixed by #5320
Closed

cp -dR --no-preserve=links d c should have different inodes #5308

sylvestre opened this issue Sep 24, 2023 · 4 comments · Fixed by #5320
Labels
good first issue For newcomers! U - cp

Comments

@sylvestre
Copy link
Contributor 
rm -rf a b c d; mkdir d; (cd d; touch a; ln a b)
./target/debug/coreutils cp -dR --no-preserve=links d c

a_inode=$(ls -i c/a|sed 's,c/.*,,')
b_inode=$(ls -i c/b|sed 's,c/.*,,')
echo "$a_inode" = "$b_inode"

We should get different inodes

See #5031 for a similar issue

On my system, why GNU:
36311653 = 36341951
with our impl:
36311653 = 36311653

Tested by
GNU test: tests/cp/link-preserve.sh
https://github.com/coreutils/coreutils/blob/master/tests/cp/link-preserve.sh#L63-L68
@sylvestre sylvestre mentioned this issue Sep 24, 2023
Closed
@tertsdiepraam
Copy link
Member

I believe this is because --no-preserve is basically ignored right now 😄

@tommady
Copy link
Contributor
tommady commented Sep 25, 2023

Hi @sylvestre
Yes I am interesting in this issue as you asked me.

May I take a shot to try this one?
Thanks.

@sylvestre
Copy link
Contributor Author

Sure :)

@tommady tommady mentioned this issue Sep 25, 2023
Merged
@cakebaker cakebaker linked a pull request Sep 25, 2023 that will close this issue
cp: fix cp -dR --no-preserve=links d c should have different inodes #5320
Merged
@sylvestre sylvestre mentioned this issue Sep 27, 2023
Closed
@sylvestre
Copy link
Contributor Author

@tommady the last one #5327 if you are still interested :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - cp
Projects
GNU Compatibility
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cp: fix cp -dR --no-preserve=links d c should have different inodes tommady/coreutils
3 participants
@sylvestre @tommady @tertsdiepraam
0