8000 cksum: show error if a directory is specified · Issue #5805 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cksum: show error if a directory is specified #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cakebaker opened this issue Jan 8, 2024 · 4 comments · Fixed by #5822
Closed

cksum: show error if a directory is specified #5805

cakebaker opened this issue Jan 8, 2024 · 4 comments · Fixed by #5822
Labels
good first issue For newcomers! U - cksum

Comments

@cakebaker
Copy link
Contributor

GNU cksum shows an error and returns an exit code of 1 if a directory is specified:

$ cksum dir file
cksum: dir: Is a directory
4294967295 0 file
$ echo $?
1

uutils cksum, on the other hand, doesn't show an error and returns an exit code of 0:

$ cargo run cksum dir file
4294967295 0 dir
4294967295 0 file
$ echo $?
0

The same applies to -a/--algorithm with all algorithms.
@tertsdiepraam
Copy link
Member

Is this a generalization of #5804? I was just thinking there that blake2b wouldn't be the only case. In #5804, the error is generated manually, but "Is a directory" usually comes from an io error. I think it's probably worth investigating what our cksum is even doing on directories.

8000

@cakebaker
Copy link
Contributor Author

Yes, it is a generalization of it.

@Ato2207
Copy link
Contributor
Ato2207 commented Jan 8, 2024

I could take on this issue too if it is ok, should be a small modification.

@cakebaker
Copy link
Contributor Author

Sure, go ahead :)

This was referenced Jan 9, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - cksum
Projects
None yet
Milestone
No milestone
3 participants
@cakebaker @tertsdiepraam @Ato2207
0