8000 Support BSD in util Bash scripts · Issue #5598 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support BSD in util Bash scripts #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcheylus opened this issue Nov 29, 2023 · 1 comment · Fixed by #5774
Closed

Support BSD in util Bash scripts #5598

lcheylus opened this issue Nov 29, 2023 · 1 comment · Fixed by #5774

Comments

@lcheylus
Copy link
Contributor
lcheylus commented Nov 29, 2023 •
edited
Loading

For Bash scripts in util/ (build-gnu.sh, run-gnu-test.sh, build-code_coverage.sh...), commands for make and readlink are not compatible with BSD OS (FreeBSD, NetBSD and OpenBSD).

  • GNU make, not compatible with make on BSD
  • readlink uses -m flag : not present for readlink on BSD, only in GNU coreutils readlink

On BSD:

  • GNU make could be installed via package (gmake on OpenBSD)
  • GNU coreutils (readlink) is available in coreutils package on OpenBSD

Proposal to modify Bash scripts to be compatible with BSD OS and Linux (with GNU coreutils installed by default)

  • checks OS and defines MAKE/READLINK variables
# Check OS to use GNU coreutils and make: specific version on *BSD
case "$OSTYPE" in
    *bsd*)
        MAKE="gmake"
        READLINK="greadlink"
        ;;
    *)
        MAKE="make"
        READLINK="readlink"
        ;;
esac
  • replace make by ${MAKE}
  • replace readlink by ${READLINK}
@sylvestre
Copy link
Contributor

Sure, don't hesitate to submit a PR

@lcheylus lcheylus mentioned this issue Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix util shell scripts to be compatible with BSD lcheylus/rust-coreutils
2 participants
@sylvestre @lcheylus
0