10000 urm self-documenation is misconfigured. · Issue #3668 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

urm self-documenation is misconfigured. #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bdmorin opened this issue Jun 24, 2022 · 1 comment · Fixed by #3670
Closed

urm self-documenation is misconfigured. #3668

bdmorin opened this issue Jun 24, 2022 · 1 comment · Fixed by #3670

Comments

@bdmorin
Copy link
bdmorin commented Jun 24, 2022

I was including /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/urm.fish in my fish shell, and found this error;

> source /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/urm.fish
complete: Too many arguments

/home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/urm.fish (line 5):
complete -c urm -s i -l prompt before every removal
^
from sourcing file /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/urm.fish


5: complete -c urm -s i -l -d 'prompt before every removal'

The -l requires an option here's my fix.

complete -c urm -s i -l prompt -d 'prompt before every removal'

However I'm assuming the completions are auto-generated
image

It seems something in the urm code has before every removal in the incorrect place, it should be aligned with the column on the right.

I tried to find it in the code, but I'm no rust developer yet.

> brew info uutils-coreutils
uutils-coreutils: stable 0.0.14 (bottled), HEAD

> urm --version
urm 0.0.14

Thanks!
@tertsdiepraam
Copy link
Member
tertsdiepraam commented Jun 24, 2022 •
edited
Loading

The completions are indeed autogenerated by clap-complete. If you can find a minimal, easy to reproduce example of this problem, we could open an issue there.

Edit: Actually the --prompt before every removal line indeed doesn't look right, arguments are not supposed to have spaces😄 This might be a mistake on our part, I'll look into it.

@tertsdiepraam tertsdiepraam mentioned this issue Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm: fix help text mistakenly being used as the long option tertsdiepraam/coreutils
2 participants
@bdmorin @tertsdiepraam
0