You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would be the reason for patches to be in their own branches rather than behind feature gates? For some complicated patches like Marvel Rivals I understand but I am mostly interested in keeping Wuthering Waves patch in sync with master. Would it be possible to move it to master branch behind feature like game_wuwa? If you want I can make a PR for that.
The text was updated successfully, but these errors were encountered:
I keep them in their own branch because they are often hacked together patches that are not well tested and integrate poorly with the rest of the library, especially when there are a bunch of them all rearranging members of the same few structs.
I also do not have the time to go back and test each patch works after touching parts of the code surrounding them. This tool tries to maintain compatibility with all official Unreal Engine pak versions, which is already quite a challenge. Going a step further and trying to maintain compatibility with all engine versions and every game introducing their own customization is not something I'm interested in, and I would more than likely end up breaking unintentionally.
For anyone interested in a patch for a specific game, I recommend forking this repo and maintaining the patch yourself, as you will be far more capable of maintaining a functioning patch for the specific game you are interested in than I am at simultaneously maintaining functional patches for every game out there.
Hey! Great job on this library!
What would be the reason for patches to be in their own branches rather than behind feature gates? For some complicated patches like Marvel Rivals I understand but I am mostly interested in keeping Wuthering Waves patch in sync with master. Would it be possible to move it to master branch behind feature like
game_wuwa
? If you want I can make a PR for that.The text was updated successfully, but these errors were encountered: