8000 About fixes for specific games · Issue #38 · trumank/repak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

About fixes for specific games #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imunproductive opened this issue Feb 5, 2025 · 1 comment
Closed

About fixes for specific games #38

imunproductive opened this issue Feb 5, 2025 · 1 comment

Comments

@imunproductive
Copy link
imunproductive commented Feb 5, 2025

Hey! Great job on this library!

What would be the reason for patches to be in their own branches rather than behind feature gates? For some complicated patches like Marvel Rivals I understand but I am mostly interested in keeping Wuthering Waves patch in sync with master. Would it be possible to move it to master branch behind feature like game_wuwa? If you want I can make a PR for that.

@trumank
Copy link
Owner
trumank commented Feb 5, 2025

I keep them in their own branch because they are often hacked together patches that are not well tested and integrate poorly with the rest of the library, especially when there are a bunch of them all rearranging members of the same few structs.

I also do not have the time to go back and test each patch works after touching parts of the code surrounding them. This tool tries to maintain compatibility with all official Unreal Engine pak versions, which is already quite a challenge. Going a step further and trying to maintain compatibility with all engine versions and every game introducing their own customization is not something I'm interested in, and I would more than likely end up breaking unintentionally.

For anyone interested in a patch for a specific game, I recommend forking this repo and maintaining the patch yourself, as you will be far more capable of maintaining a functioning patch for the specific game you are interested in than I am at simultaneously maintaining functional patches for every game out there.

ref #33 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0