8000 Doesn't compile on Ubuntu 24.04 · Issue #1131 · trezor/blockbook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Doesn't compile on Ubuntu 24.04 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
j1warren opened this issue Sep 15, 2024 · 3 comments
Open

Doesn't compile on Ubuntu 24.04 #1131

j1warren opened this issue Sep 15, 2024 · 3 comments

Comments

@j1warren
Copy link

see here
#45 (comment)
@j1warren
Copy link
Author

facebook/rocksdb@88edfbf
https://github.com/facebook/rocksdb/pull/12171/files

Fixed it with this in build/docker/bin/Dockerfile

# install rocksdb
RUN cd /opt && git clone -b $ROCKSDB_VERSION --depth 1 https://github.com/facebook/rocksdb.git
+RUN cd /opt/rocksdb && sed -i '8i #include <cstdint>' table/block_based/data_block_hash_index.h && sed -i '9i #include <cstdint>' util/string_util.h && sed -i '11i #include <cstdint>' include/rocksdb/utilities/checkpoint.h
+RUN cd /opt/rocksdb && CFLAGS=-fPIC CXXFLAGS="-fPIC -Wno-error=redundant-move" PORTABLE=$PORTABLE_ROCKSDB make -j 4 release
-RUN cd /opt/rocksdb && CFLAGS=-fPIC CXXFLAGS=-fPIC PORTABLE=$PORTABLE_ROCKSDB make -j 4 release
RUN strip /opt/rocksdb/ldb /opt/rocksdb/sst_dump && \
    cp /opt/rocksdb/ldb /opt/rocksdb/sst_dump /build

@grdddj grdddj mentioned this issue Oct 15, 2024
Merged
@ogunden
Copy link
ogunden commented Apr 19, 2025

Just confirmed this issue is still outstanding at blockbook commit bcc68b8.

Also confirmed that adding the sed line above to build/docker/bin/Dockerfile fixes it. I didn't have to add the -Wno-error=redundant-move however. It looks like that's been taken care of by the addition of DISABLE_WARNING_AS_ERROR=1.

@cpuchainorg
Copy link
Contributor

It compiles and I don't recommend to use default Dockerfile as it only compiles one deb per one coin

https://github.com/cpuchain/blockbook-docker/blob/main/Dockerfile

You can refer my script or refer others from other github repository to produce minimal multi-coin image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ogunden @j1warren @cpuchainorg
0