8000 Rendering issue - sometimes with building:part, outline and type=building · Issue #229 · tordanik/OSM2World · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rendering issue - sometimes with building:part, outline and type=building #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HikeAndMap opened this issue Jan 8, 2025 · 6 comments
Open

Rendering issue - sometimes with building:part, outline and type=building #229

HikeAndMap opened this issue Jan 8, 2025 · 6 comments
Labels
bug

Comments

@HikeAndMap
Copy link

The screenshot shows the object in OSM
image

The screenshot below is the outline
image

The screenshot below is building:part (which is the same as the outline just a different relationship)
image

Below is the building:part for roof wall
image

And below the skillion roof
image

below is then type=building to group them all together
image

No errors from JOSM - yet see what I get rendered in OSM2World
image
@HikeAndMap
Copy link
Author

Please by all means, if I do something wrong - kindly explain to me.. thank you

@HikeAndMap
Copy link
Author

If I remove the type=building
with the outline and 3 building parts..

Delete the type=building relationship
delete the building:part which is a copy of the outline
and rename the other 2 building:part into building=

then it renders okay:
image

But that's lyin 8000 g.. that's mapping for the renderer but not the reality.
The reality is there's not 3 buildings on top of each other.
it's 1 building with 3 building parts..

@HikeAndMap
Copy link
Author
HikeAndMap commented Jan 8, 2025 •
edited
Loading

Ah building:level on the outline creates the bug..

so building:level can't be defined on the outline or else building:part will have problems with rendering.

I won't close this - as it may be a bug.
but maybe it's not, if it's intentional feel free for the devs to close it with the comment:"building:levels is per design intentional to interfere with the rendering"

as I thought from OSM Wiki if height and min_height are defined then hat overrides building:level

but for 2D backwards compatibility one still adds it..

seems the renderer however doesn't like it so I just remove it.. but again, maybe the devs find it worth to work on this to ensure backwards compatibility - so I leave it up to the devs to close/not close this one

@tordanik
Copy link
Owner

In general, adding building:levels to the outline is correct even if the building's parts are mapped individually. So this might be a genuine bug.

As with the other issue, an .osm file would be helpful to reproduce the issue more easily.

@HikeAndMap
Copy link
Author
HikeAndMap commented Jan 15, 2025 •
edited
Loading

Dear Tordanik, thank you for the reply.

With the following zip file (building:levels=1 in the outline) this is what I see:
image
false.zip

@HikeAndMap
Copy link
Author

The following has building:levels=1 removed and this is what I get
image
good.zip

@HikeAndMap HikeAndMap mentioned this issue Jan 15, 2025
Closed
@tordanik tordanik added the bug label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tordanik @HikeAndMap
0