8000 The solution for 3.6 is wrong · Issue #37 · torbiak/gopl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

The solution for 3.6 is wrong #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SingularReza opened this issue Jan 20, 2022 · 1 comment
Open

The solution for 3.6 is wrong #37

SingularReza opened this issue Jan 20, 2022 · 1 comment

Comments

@SingularReza
Copy link

Instead of averaging over the subpixels, it is sampling the pixels diagonal to the one being worked on, making the end result same as the one without super sampling. Changing epsX and epsY to 1/width and 1/height would be the correct way
@denisbr
Copy link
denisbr commented Jul 19, 2022

I tested this code, and found that due to the way the constants are initialised, epsX and epsY end up being 0, so in effect there is no supersampling performed. Explicitly initialising epsX and epsY as floats seemed to work better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denisbr @SingularReza
0