8000 Release 1.6.0 discussion by rockymeza · Pull Request #268 · moment/moment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release 1.6.0 discussion #268

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Release 1.6.0 discussion #268

wants to merge 1 commit into from

Conversation

rockymeza
Copy link
Contributor

Note: this pull request is not ready to be merged in.

I am opening up the version 1.6.0 release for discussion. In this pull request, I think we should talk about the features that need to be added or removed before we can cut a new version of moment. Here are some changes that I think should be in version 1.6.

Languages

To be removed

New Features that have already been written

New features that have not been written

Things that should not go into this release

@timrwood
Copy link
Member
timrwood commented Apr 8, 2012

We should also add moment.lang() as a getter as well. See #266.

This would be a good workaround before adding per instance lang configurations.

@timrwood
Copy link
Member

FYI, I updated the list.

The new parser ended up taking much less time than I thought it would. It passes all the previous tests, plus the new 'YYYMMDD' tests. I think it's pretty stable, so it should be good to release.

I added lang as a getter, and moved the S/SS/SSS parsing issue up to the 'have been written' section.

I also added moment.fn.isValid and two letter month names to the 'not this release' section.

@timrwood
Copy link
Member

I added these to the 'already written' section, and moved durations there as well.

@timrwood
Copy link
Member

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

@rockymeza
Copy link
Contributor Author

Looks like a good solid release to me. What about that Korean bug? We
could probably stick that in too.
-rocky

On Tue, Apr 24, 2012 at 6:19 PM, Tim Wood <
reply@reply.github.com

wrote:

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

Reply to this email directly or view it on GitHub:
#268 (comment)

@rockymeza
Copy link
Contributor Author

Nevermind, #284 seems to be a problem with incompatible versions of moment and and the kr.js file.

I think we're good to go @timrwood.

@timrwood
Copy link
Member

Cool, all that is left is adding docs for durations and ender compatibility. I've created placeholders, so hopefully I can get it all written tonight. I'll ping you so you can double check them before I make the release.

@timrwood
Copy link
Member

@rockymeza, I added docs for durations, please check it out over on https://github.com/timrwood/momentjs.com. Everything is just in the master branch there for now. (After 1.6.0 release, I think I'll switch that to git flow as well).

I also made you a collaborator on that site, so you should be able to push changes there as well.

After you look over the docs, I'll release 1.6.0.

@timrwood
Copy link
Member

This is released!

@timrwood timrwood closed this Apr 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockymeza @timrwood
0