"External Diff" and "External Editor" not always evidently related 8000 to context #61
Labels
bug
entry level
Marks issues that can be easily addressed by new developers just starting with this project.
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
"External Diff" allows opening an external app with the modifications applied to current selected file in a commit. "External Editor" allows opening an external app with the currently selected file (either in the file tree view or in a commit file list).
These actions are always active when a file is selected, either in the file tree view or in a commit file list view. If the file tree view is collapsed and there is no selection in the current commit's file list view, both these actions remain active and it is not clear from the context why. Furthermore, the "External Diff", when invoked, will open with an empty diff (because the hidden selected file in the file tree view has no diff context attached to it).
TODO: deactivate "External Diff" and "External Editor" actions when the file tree view is not visible. Deactivate the "External Diff" action when the selected file has no diff context (is not selected as part of a commit).
The text was updated successfully, but these errors were encountered: