8000 handle swagger, redoc and openapi with coroutine function by trim21 · Pull Request #241 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle swagger, redoc and openapi with coroutine function #241

Merged
merged 3 commits into from
May 20, 2019
Merged

handle swagger, redoc and openapi with coroutine function #241

merged 3 commits into from
May 20, 2019

Conversation

trim21
Copy link
Contributor
@trim21 trim21 commented May 20, 2019

close #238

@codecov
Copy link
codecov bot commented May 20, 2019 •
edited
Loading

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #241   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         175    175           
  Lines        4261   4268    +7     
=====================================
+ Hits         4261   4268    +7
Impacted Files Coverage Δ
fastapi/applications.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf92a1...875c472. Read the comment docs.

tiangolo
tiangolo requested changes May 20, 2019
View reviewed changes
Copy link
Member
@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! That was fast! ⚡

Please help me refactor a couple of things to move some stuff to fastapi.openapi.docs.

Thanks!

fastapi/applications.py Show resolved Hide resolved
fastapi/applications.py Show resolved Hide resolved
@trim21
Copy link
Contributor Author
trim21 commented May 20, 2019

Sorry for wrong click

@tiangolo tiangolo merged commit 01b43e6 into fastapi:master May 20, 2019
@tiangolo
Copy link
Member

Thanks for implementing the changes, you did it correctly. And it made me realize all the complexity involved in having them as separate functions, as they depended on variables from outside. So I reverted it to your original implementation.

I just merged it. Thank you! 🎉 🚀 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make swagger_ui_html, redoc_html and openapi.json handled by async function?
2 participants
@trim21 @tiangolo
0