8000 📝 Fix renamed parameter `content_type` typo by TeoZosa · Pull Request #2135 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Fix renamed parameter content_type typo #2135

Merged
merged 2 commits into from
Nov 5, 2020
Merged

📝 Fix renamed parameter content_type typo #2135

merged 2 commits into from
Nov 5, 2020

Conversation

TeoZosa
Copy link
Contributor
@TeoZosa TeoZosa commented Oct 5, 2020

The content_type parameter was renamed to response_class in release 0.19.0

Tangential question to maintainers:

This is the 3rd documentation-related PR I've opened this week. They all fall into different categories, but all have fairly small changes.

  • Is this disruptive?
  • Would it be better to condense any near-future PRs into a single "documentation" PR?

Thanks in advance!

@codecov
Copy link
codecov bot commented Oct 5, 2020

Codecov Report

Merging #2135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ea63...1d9f1ad. Read the comment docs.

@github-actions
Copy link
Contributor
github-actions bot commented Oct 5, 2020

📝 Docs preview for commit 1d9f1ad at: https://5f7b7021d6d83e2d86a400a7--fastapi.netlify.app

@tiangolo tiangolo changed the title Fix renamed parameter content_type typo 📝 Fix renamed parameter content_type typo Nov 5, 2020
@tiangolo tiangolo merged commit 730ded2 into fastapi:master Nov 5, 2020
@tiangolo
Copy link
Member
tiangolo commented Nov 5, 2020

Awesome! Thank you @TeoZosa ! 🔍 ☕

About the question, it's perfect like this, in different PRs. That way if for example, I didn't want to accept one of them but I wanted the other 3, I could just merge the other 3.

But if it was all in a single PR, I wouldn't be able to merge all the things from the other 3, waiting for changes to that little thing I didn't want.

Thanks for your contribution! 🍰 🎉

@TeoZosa
Copy link
Contributor Author
TeoZosa commented Nov 6, 2020

Awesome! Thank you @TeoZosa ! 🔍 ☕

About the question, it's perfect like this, in different PRs. That way if for example, I didn't want to accept one of them but I wanted the other 3, I could just merge the other 3.

But if it was all in a single PR, I wouldn't be able to merge all the things from the other 3, waiting for changes to that little thing I didn't want.

Thanks for your contribution! 🍰 🎉

Perfect! Thanks for the feedback!

@TeoZosa TeoZosa deleted the fix-renamed-parameter-content_type-typo branch November 6, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeoZosa @tiangolo
0