8000 🌐 Add Japanese translation for Tutorial - Query Parameters and String Validations by SwftAlpc · Pull Request #1901 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for Tutorial - Query Parameters and String Validations #1901

Merged
merged 35 commits into from
Nov 1, 2020
Merged

🌐 Add Japanese translation for Tutorial - Query Parameters and String Validations #1901

merged 35 commits into from
Nov 1, 2020
+303 −0

Conversation

SwftAlpc
Copy link
Contributor
@SwftAlpc SwftAlpc commented Aug 16, 2020 •
edited
Loading

This PR translates the tutorial/query-params-str-validations.md to Japanese.
Please review tutorial/query-params-str-validations.md

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 16, 2020
Closed
@codecov
Copy link
codecov bot commented Aug 16, 2020 •
edited
Loading

Codecov Report

Merging #1901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1901   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f495d98...9bd89f9. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4b1a9b8 at: https://5f38f867ad43c4776fa78b35--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 792b4f2 at: https://5f3906301c8489b832facee3--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 16, 2020
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thank you for your review!
I fixed it.

@github-actions
8000
Copy link
Contributor

📝 Docs preview for commit 1d6e078 at: https://5f3ea0b9ca4acadea6b9034a--fastapi.netlify.app

tokusumi
tokusumi suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor
@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most "hl_lines" is two less than original text.

docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
@SwftAlpc
Copy link
Contributor Author

@tokusumi
I thought I was referring to the latest documentation in the English version, but I was wrong.
It has been corrected and I would appreciate a re-review.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8b3a708 at: https://5f415294560aaadfdde64398--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 3aa2842 at: https://5f4cb0f3cff5d0bc667c644b--fastapi.netlify.app

Attsun1031
Attsun1031 reviewed Oct 4, 2020
View reviewed changes
Copy link
Contributor
@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work !
Please check suggestions I made.

docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit abf0347 at: https://5f9a984679314824e1141b09--fastapi.netlify.app

SwftAlpc and others added 15 commits October 29, 2020 19:25
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
cc66eb8 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
fac0999 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
0e32628 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
5b68148 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
990de04 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
f19ce4d 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
0bcdc67 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
fc52c9a 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
d28a5c5 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
3ad3205 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
aac9de6 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
b416f23 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
67d1f1b 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
b93c716 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@SwftAlpc @Attsun1031
Update docs/ja/docs/tutorial/query-params-str-validations.md
9bd89f9 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 9bd89f9 at: https://5f9a9ad84b7d4727f39b7817--fastapi.netlify.app

@SwftAlpc
Copy link
Contributor Author

@Attsun1031
Thanks for the review!
Could you re-review it that has been corrected?

Attsun1031
Attsun1031 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor
@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiangolo
Copy link
Member
tiangolo commented Nov 1, 2020

Awesome, thanks @SwftAlpc ! 👏

And thanks @Attsun1031 and @tokusumi for the reviews 🙇

@tiangolo tiangolo changed the title Add tutorial/query-params-str-validations.md 🌐 Add Japanese translation for Tutorial - Query Parameters and String Validations Nov 1, 2020
@tiangolo tiangolo merged commit 76632fc into fastapi:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

@Attsun1031 Attsun1031 Attsun1031 approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwftAlpc @tiangolo @Attsun1031 @tokusumi @ryuckel
0