8000 Starlette up version by euri10 · Pull Request #17 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starlette up version #17

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Starlette up version #17

merged 5 commits into from
Feb 1, 2019

Conversation

euri10
Copy link
Contributor
@euri10 euri10 commented Jan 30, 2019

Should fix #10

@codecov
Copy link
codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines        2462   2462           
=====================================
  Hits         2462   2462
Impacted Files Coverage Δ
fastapi/routing.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014c7df...45a62ce. Read the comment docs.

@tiangolo
Copy link
Member

Thanks! I'll check it soon.

@tiangolo tiangolo merged commit 5c9c088 into fastapi:master Feb 1, 2019
@tiangolo
Copy link
Member
tiangolo commented Feb 1, 2019

Awesome, thanks! Merged ✔️

@euri10 euri10 deleted the starlette_up_version branch February 1, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

starlette update breaks routing
2 participants
@euri10 @tiangolo
0