Better JSON Decode error handling #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in case JSON decode failure
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 226 227 +1
Lines 6785 6813 +28
=========================================
+ Hits 6785 6813 +28
Continue to review full report at Codecov.
|
|
@tiangolo Seems the new handling leaves the generic exception handling uncovered. Not sure how to trigger that exception now tho, would assume connection breaking or something similar. ideas? |
|
Added missing test for full coverage, pending CR @tiangolo . |
|
Awesome! Very nice 👌 ✨ Impeccable implementation and tests ✔️ 🚀 Thanks for your contribution! 🎉 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by the fact that if JSON parsing fails for the body you receive HTTP Exception 400.
I think RequestValidationError is a better suit for the case, for the client to realize what have he done wrong exactly (position of wrong character) and body to be part of the exception (so it can be logged)