8000 Add Chinese tranlation for docs/python-types.md by waynerv · Pull Request #1197 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese tranlation for docs/python-types.md #1197

Merged
merged 3 commits into from
May 24, 2020
Merged

Add Chinese tranlation for docs/python-types.md #1197

merged 3 commits into from
May 24, 2020

Conversation

waynerv
Copy link
Contributor
@waynerv waynerv commented Mar 31, 2020

No description provided.

@codecov
Copy link
codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         6805      6805           
=========================================
  Hits          6805      6805

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d8eb...523369b. Read the comment docs.

RunningIkkyu
RunningIkkyu approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor
@RunningIkkyu RunningIkkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tiangolo
Copy link
Member

Thank you @waynerv for your contribution! 🚀 🙇

And thanks @RunningIkkyu for the review/approval! ☕ 🍰

I'll just wait for an approval review from someone else before merging.

Maybe @Dustyposa or @phy25 , if you have the chance, could you review this? 🙏

phy25
phy25 approved these changes May 17, 2020
View reviewed changes
Copy link
@phy25 phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine. Not sure how high the standard will be, but I saw some weird spaces between text and “”（） which doesn't feel quite right.

docs/zh/docs/python-types.md Outdated Show resolved Hide resolved
@tiangolo tiangolo merged commit 374cdf2 into fastapi:master May 24, 2020
@tiangolo
Copy link
Member

Awesome! Thank you @waynerv ! 🍰 🎉

And thanks @phy25 for the review 🙇 👏

@waynerv waynerv deleted the translate-python-types-doc branch May 24, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunningIkkyu RunningIkkyu RunningIkkyu approved these changes

@phy25 phy25 phy25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynerv @tiangolo @phy25 @RunningIkkyu
0