8000 🌐 Add Turkish translation for `docs/tr/docs/history-design-future.md` by hasansezertasan · Pull Request #11012 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Turkish translation for docs/tr/docs/history-design-future.md #11012

Merged
merged 11 commits into from
Jan 25, 2024
Merged

🌐 Add Turkish translation for docs/tr/docs/history-design-future.md #11012

merged 11 commits into from
Jan 25, 2024

Conversation

hasansezertasan
Copy link
Contributor
@hasansezertasan hasansezertasan commented Jan 23, 2024 •
edited
Loading

🌐 Add Turkish translation for docs/tr/docs/history-design-future.md

Original File

Discussion: #9193

@hasansezertasan hasansezertasan changed the title 🌐 Add Turkish translation for docs/tr/docs/about/history-design-future.md' 🌐 Add Turkish translation for docs/tr/docs/history-design-future.md' Jan 23, 2024
@hasansezertasan hasansezertasan changed the title 🌐 Add Turkish translation for docs/tr/docs/history-design-future.md' 🌐 Add Turkish translation for docs/tr/docs/history-design-future.md Jan 23, 2024
@tiangolo
Copy link
Member

📝 Docs preview for commit d38dd62 at: https://89e38dd4.fastapitiangolo.pages.dev

@hasansezertasan
Copy link
Contributor Author

@alperiox, @OzgunCaglarArslan @SametEmin, @mertssmnoglu, can you please leave a review?

@alejsdev alejsdev added lang-all Translations awaiting-review lang-tr Turkish translations labels Jan 23, 2024
mertssmnoglu
mertssmnoglu suggested changes Jan 23, 2024
View reviewed changes
Copy link
@mertssmnoglu mertssmnoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear explanation.
As general it's very good. But it can be more understandable the changes that i prefer. What do you think about them? @hasansezertasan

docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
@hasansezertasan
Copy link
Contributor Author

Thank you @mertssmnoglu for the review. It improved the translation a lot! Can you take a look at it again?

alperiox
alperiox reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor
@alperiox alperiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty nice, I added minor changes that may fit better to the given context.

docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
hasansezertasan and others added 4 commits January 23, 2024 19:26
@hasansezertasan @alperiox
Update docs/tr/docs/history-design-future.md
8ec168e 
Co-authored-by: Alper <itsc0508@gmail.com>
@hasansezertasan @alperiox
Update docs/tr/docs/history-design-future.md
149b18b 
Co-authored-by: Alper <itsc0508@gmail.com>
@hasansezertasan @alperiox
Update docs/tr/docs/history-design-future.md
7f0fd3c 
Co-authored-by: Alper <itsc0508@gmail.com>
@hasansezertasan @alperiox
Update docs/tr/docs/history-design-future.md
7b13f7b 
Co-authored-by: Alper <itsc0508@gmail.com>
alperiox
alperiox approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor
@alperiox alperiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is pretty accurate now, thank you for the hard work!

@hasansezertasan
Copy link
Contributor Author

I think it is pretty accurate now, thank you for the hard work!

Thank you for the great review 🙏

@tiangolo
Copy link
Member

📝 Docs preview for commit 6082448 at: https://491d1788.fastapitiangolo.pages.dev

@hasansezertasan @alperiox
Update docs/tr/docs/history-design-future.md
8415434 
Co-authored-by: Alper <itsc0508@gmail.com>
@tiangolo
Copy link
Member

📝 Docs preview for commit 8415434 at: https://4f6317fd.fastapitiangolo.pages.dev

@egndz
Copy link
egndz commented Jan 24, 2024

pretty good one and easily understandable by Turkish speakers. Cheers!

@hasansezertasan
Copy link
Contributor Author

Thank you @OzgunCaglarArslan for the review!

OzgunCaglarArslan
OzgunCaglarArslan suggested changes Jan 24, 2024
View reviewed changes
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
docs/tr/docs/history-design-future.md Outdated Show resolved Hide resolved
hasansezertasan and others added 2 commits January 24, 2024 17:21
@hasansezertasan
Update docs/tr/docs/history-design-future.md
8e66bc4
@hasansezertasan @OzgunCaglarArslan
Update docs/tr/docs/history-design-future.md
5484a23 
Co-authored-by: OzgunCaglarArslan <86166426+OzgunCaglarArslan@users.noreply.github.com>
@hasansezertasan
Copy link
Contributor Author

Thank you @OzgunCaglarArslan for the review. I fixed the parts you highlighter. Can you please take a look at it again?

@tiangolo
Copy link
Member

📝 Docs preview for commit 5484a23 at: https://ad62af8c.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit 5d74e58 into fastapi:master Jan 25, 2024
41 checks passed
@alejsdev
Copy link
Member

Thank you for your contribution! @hasansezertasan 🤓💯

And thanks for the reviews @mertssmnoglu @alperiox and @OzgunCaglarArslan 🚀✨

@hasansezertasan hasansezertasan deleted the tr/history-design-future.md branch January 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperiox alperiox alperiox approved these changes

@mertssmnoglu mertssmnoglu mertssmnoglu approved these changes

@OzgunCaglarArslan OzgunCaglarArslan Awaiting requested review from OzgunCaglarArslan

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-tr Turkish translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hasansezertasan @tiangolo @egndz @alejsdev @alperiox @mertssmnoglu @OzgunCaglarArslan
0