8000 ✏️ Fix typos in `docs/en/docs/alternatives.md` and `docs/en/docs/tutorial/dependencies/index.md` by s111d · Pull Request #10906 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix typos in docs/en/docs/alternatives.md and docs/en/docs/tutorial/dependencies/index.md #10906

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

s111d
Copy link
Contributor
@s111d s111d commented Jan 8, 2024

Looks like "plug-ins" is used across the docs, and it is a common plural form in general.

P.S.: somebody with native English please check the next paragraph, namely "way that allow" – shouldn't there be "allowS" (or "will allow" alternatively)?

Looks like "plug-ins" is used across the docs, and it is a common plural form in general.
@tiangolo
Copy link
Member
tiangolo commented Jan 8, 2024

📝 Docs preview for commit 16f352b at: https://b927d9bc.fastapitiangolo.pages.dev

No hyphen needed here.
@tiangolo
Copy link
Member
tiangolo commented Jan 8, 2024

📝 Docs preview for commit 39f2ebc at: https://384c2bce.fastapitiangolo.pages.dev

@s111d
Copy link
Contributor Author
s111d commented Jan 8, 2024

NOTE: https://fastapi.tiangolo.com/alternatives/#starlette
– ASGI hover reads "The new standard for building asynchronous Python web" – shouldn't it end with "applications" or it is left like this intentionally?

@aanchlia
Copy link
Contributor
aanchlia commented Jan 9, 2024

Looks like "plug-ins" is used across the docs, and it is a common plural form in general.

P.S.: somebody with native English please check the next paragraph, namely "way that allow" – shouldn't there be "allowS" (or "will allow" alternatively)?

Yeah, should be way that allows. Can you make that change too ?

@s111d
Copy link
Contributor Author
s111d commented Jan 9, 2024

Looks like "plug-ins" is used across the docs, and it is a common plural form in general.
P.S.: so 8000 mebody with native English please check the next paragraph, namely "way that allow" – shouldn't there be "allowS" (or "will allow" alternatively)?

Yeah, should be way that allows. Can you make that change too ?

Done:339e5bc

@alejsdev alejsdev changed the title Fix typo: inconsistent term usage ✏️ Fix typo in docs/en/docs/alternatives.md and docs/en/docs/tutorial/dependencies/index.md Jan 9, 2024
@tiangolo
Copy link
Member
tiangolo commented Jan 9, 2024

Nice, thank you @s111d! 🔍

And thanks for the reviews @hasansezertasan, @alejsdev 🙇

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Jan 9, 2024
@tiangolo tiangolo changed the title ✏️ Fix typo in docs/en/docs/alternatives.md and docs/en/docs/tutorial/dependencies/index.md ✏️ Fix typos in docs/en/docs/alternatives.md and docs/en/docs/tutorial/dependencies/index.md Jan 9, 2024
@tiangolo
Copy link
Member
tiangolo commented Jan 9, 2024

NOTE: fastapi.tiangolo.com/alternatives/#starlette
– ASGI hover reads "The new standard for building asynchronous Python web" – shouldn't it end with "applications" or it is left like this intentionally?

This was intentional, thinking that it would refer to both application frameworks and servers, but it makes sense that it sounds clearer with "applications" there, I just added it here! 🤓

@tiangolo tiangolo enabled auto-merge (squash) January 9, 2024 16:43
@tiangolo tiangolo merged commit f43fc82 into fastapi:master Jan 9, 2024
36 checks passed
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0