✏️ Fix typo in dependencies with yield source examples #10847
Conversation
|
Hello @tiangolo, It's great that you fixed this! 🎉 Why I'm pointing this out 🤔I see that It would be great if you consider looking among the community for an additional maintainer. Thanks for your attention! 🙇🏻♂️ |
|
Thanks @Jamim! Yep, I have a lot of PRs to review, but there were several features I had to handle myself first, like the refactor of the dependencies, and then the upgrades to Starlette (that was blocked by that). I noticed the typo in a comment somewhere else and fixed it quickly, but wasn't able to go through the PRs to see that someone had already proposed a fix (my bad 😬). Of course, I would love all the maintainer help I can have! Would you like to help? There are several things to do, mainly answering questions in discussions and reviewing PRs (BTW, the count of PRs should exclude translations, I can't merge those unless there are 2 reviews from native speakers.). That takes a lot of work and bandwidth, and if it's not me alone, then I would have much more time to review the things that were already reviewed, merge PRs that are actually ready, and answer questions or fix bugs that have no other answer... for example, lots and lots of questions are actually errors from the user side, not problems in FastAPI, or the lack of reading the docs, the same for many PRs. Or there are many incomplete PRs, without tests, or that no one else pulled the changes and checked them locally. Most of the big chunk of the "maintainer" work can be done by anyone that wants to help, all the instructions are in the docs: https://fastapi.tiangolo.com/help-fastapi/#help-maintain-fastapi |
|
Thank you for being so open on this topic! I really appreciate it! ❤️
Sure, I'm happy to be helpful, so I'll try to do it the way you suggested. |
I do it this way, so that I can keep reordering commits (doing it via the GitHub "sync fork" button breaks this feature) Note that, because I do it like this, the GitHub GUI will assume that this branch is out of sync with the master branch. But that's not the case, this branch is in sync. 📝 Restructure Docs section in Contributing page (fastapi#10844) 📝 Restructure Docs section in Contributing page 📝 Update release notes 📝 Add docs: Node.js script alternative to update OpenAPI for generated clients (fastapi#10845) 📝 Update release notes ⬆️ Upgrade Starlette to 0.28.0 (fastapi#9636) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com> 📝 Update release notes 🔖 Release version 0.107.0 ⬆️ Upgrade Starlette to `>=0.29.0,<0.33.0`, update docs and usage of templates with new Starlette arguments (fastapi#10846) * 📝 Update docs for compatibility with Starlette 0.29.0 and new template arguments * ⬆️ Upgrade Starlette to >=0.29.0,<0.33.0 * 📌 Remove AnyIO pin 📝 Update release notes 🔖 Release version 0.108.0 ✏️ Fix typo in dependencies with yield source examples (fastapi#10847) 📝 Update release notes ✏️ Fix typo in release notes
✏️ Fix typo in dependencies with yield source examples