🐛 Fix JSON Schema accepting bools as valid JSON Schemas, e.g. additionalProperties: false
#9781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
wdh99
pushed a commit
to wdh99/fastapi
that referenced
this pull request
Jul 4, 2023
…onalProperties: false` (fastapi#9781) * 🐛 Fix JSON Schema accepting bools as valid JSON Schemas, e.g. additionalProperties: false * ✅ Add test to ensure additionalProperties can be false * ♻️ Tweak OpenAPI models to support Pydantic v1's JSON Schema for tuples
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix JSON Schema accepting bools as valid JSON Schemas, e.g.
additionalProperties: falseThis solves: #9780
A "valid JSON Schema" includes a
bool(i.e.trueandfalse).additionalPropertiesdoesn't have to be a JSON object, it can befalse, to mean no additional properties are allowed.When I upgraded the JSON Schema models to include the new types and fields for the new JSON Schema 2020-12 I removed
boolas a valid JSON Schema.I reviewed all the spec again, this updates all the other fields that would allow
boolas a valid value.