8000 📝 Update example source files for SQL databases with SQLAlchemy by s-mustafa · Pull Request #9508 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Update example source files for SQL databases with SQLAlchemy #9508

Merged
merged 2 commits into from
Jan 9, 2024
Merged

📝 Update example source files for SQL databases with SQLAlchemy #9508

merged 2 commits into from
Jan 9, 2024

Conversation

s-mustafa
Copy link
Contributor

Adding a secondary index to a primary key is not necessary.

@s-mustafa s-mustafa changed the title Update docs_src to remove useless index 📝 Update docs_src to remove useless index May 9, 2023
@github-actions
Copy link
Contributor
github-actions bot commented May 9, 2023

📝 Docs preview for commit dba9733 at: https://645a09454c03c83c4b2f2175--fastapi.netlify.app

Ryandaydev
Ryandaydev approved these changes May 17, 2023
View reviewed changes
Copy link
@Ryandaydev Ryandaydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes intuitive sense, and I verified SQLAlchemy doco does not include the index=true for its examples of defining primary keys.

Tests also pass.

@tiangolo
Copy link
Member

📝 Docs preview for commit 077a31f at: https://64b6f023ad95e206b42d3dc0--fastapi.netlify.app

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 2, 2023
@tiangolo tiangolo changed the title 📝 Update docs_src to remove useless index 📝 Update example source files for SQL databases with SQLAlchemy Jan 9, 2024
@tiangolo
Copy link
Member
tiangolo commented 8000 Jan 9, 2024

Thank you! ☕ 🍰

@tiangolo tiangolo merged commit 4491ea6 into fastapi:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

@Ryandaydev Ryandaydev Ryandaydev approved these changes

Assignees
No one assigned
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-mustafa @tiangolo @Ryandaydev @Kludex
0