8000 ♻ Remove `media_type` from `ORJSONResponse` as it's inherited from the parent class by Kludex · Pull Request #5805 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻ Remove media_type from ORJSONResponse as it's inherited from the parent class #5805

Merged
merged 3 commits into from
Jun 10, 2023
Merged

♻ Remove media_type from ORJSONResponse as it's inherited from the parent class #5805

merged 3 commits into from
Jun 10, 2023
+0 −2

Conversation

Kludex
Copy link
Member
@Kludex Kludex commented Dec 20, 2022

I just noticed... Since UJSONResponse also doesn't have it explicitly, I've removed from ORJSONResponse.

Ref.: https://github.com/encode/starlette/blob/d7558515020f4c0a96b199880c181a40678b18d5/starlette/responses.py#L182

@github-actions
Copy link
Contributor

📝 Docs preview for commit fd6a964 at: https://63a1cc57b5043502d778a687--fastapi.netlify.app

iudeen
iudeen approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor
@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tiangolo tiangolo changed the title Remove media_type from ORJSONResponse ♻ Remove media_type from ORJSONResponse as it's inherited from the parent class Jun 10, 2023
@tiangolo
Copy link
Member

Yep, nice, thanks @Kludex! 🚀

And thanks everyone for the reviews ☕

@tiangolo tiangolo enabled auto-merge (squash) June 10, 2023 12:07
@tiangolo
Copy link
Member

📝 Docs preview for commit 1523655 at: https://6484ac8eb6fff37f3e2efd9b--fastapi.netlify.app

@tiangolo tiangolo merged commit 52fd0af into fastapi:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

@nurettn nurettn nurettn approved these changes

@iudeen iudeen iudeen approved these changes

@nzig nzig nzig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kludex @tiangolo @nzig @iudeen @nurettn @yezz123
0