✏ Fix typo in docs about contributing, for compatibility with pip in Zsh
#5523
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13946 13946
=========================================
Hits 13946 13946 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
📝 Docs preview for commit 754fe3f at: https://6350e7f6d471d66daba0e771--fastapi.netlify.app |
There was a problem hiding this comment.
I have tested the change on bash as well, and it still works. So, this change makes it work on both bash ans zsh, while previously it would only work on bash. I'd recommend to merge this change in the docs. It was originally missed by PR #3131 which was merged (as later on, FastAPI moved away from Flit).
|
📝 Docs preview for commit 6d5d9d3 at: https://635b2b484f301710a309ae07--fastapi.netlify.app |
pip in Zsh
|
Awesome, good catch, thanks for the contribution @zhangbo2012! 🍰 And thanks for the reviews everyone, in particular @JarroVGIT, the comments telling me exactly what you tested and checked, help me a lot and help me see that you did review it. 🤓 |
with zsh, use command
python -m pip install -e .[dev,doc,test]not workingUpdate to
python -m pip install -e ."[dev,doc,test]", It worked