✏ Update Hypercorn link, now pointing to GitHub #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Uvicorn link from gitlab to github to reflect current hosting https://gitlab.com/pgjones/hypercorn/-/commit/65e539a9dc762cb19f4907038fe6d490dac909ff
|
📝 Docs preview for commit b74135e at: https://63146b95ea029449b4f616d7--fastapi.netlify.app |
iudeen
suggested changes
Sep 4, 2022
iudeen
suggested changes
Sep 4, 2022
| @@ -128,7 +128,7 @@ $ pip install fastapi | |||
|
|
|||
| </div> | |||
|
|
|||
| You will also need an ASGI server, for production such as <a href="https://www.uvicorn.org" class="external-link" target="_blank">Uvicorn</a> or <a href="https://gitlab.com/pgjones/hypercorn" class="external-link" target="_blank">Hypercorn</a>. | |||
| You will also need an ASGI server, for production such as <a href="https://www.uvicorn.org" class="external-link" target="_blank">Uvicorn</a> or <a href="https://github.com/pgjones/hypercorn" class="external-link" target="_blank">Hypercorn</a>. | |||
There was a problem hiding this comment.
Suggested change
| You will also need an ASGI server, for production such as <a href="https://www.uvicorn.org" class="external-link" target="_blank">Uvicorn</a> or <a href="https://github.com/pgjones/hypercorn" class="external-link" target="_blank">Hypercorn</a>. | |
| You will also need an ASGI server, for production such as <a href="https://www.uvicorn.org" class="external-link" target="_blank">Uvicorn</a> or <a href="https://hypercorn.readthedocs.io/" class="external-link" target="_blank">Hypercorn</a>. |
Sorry about that, was half asleep there |
|
📝 Docs preview for commit 6aea685 at: https://6314b832892a157d58638265--fastapi.netlify.app |
|
Nice, thanks @baconfield! 🍰 And thanks for the help @iudeen! |
Codecov Report
@@ Coverage Diff @@
## master #5346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 539 539
Lines 13902 13902
=========================================
Hits 13902 13902 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kittydoor
added a commit
to kittydoor/fastapi
that referenced
this pull request
Jun 20, 2024
PR fastapi#5346 seems to have partially done this already, however a lot of references are still outdated in the docs. This commit updates all remainders.
kittydoor
added a commit
to kittydoor/fastapi
that referenced
this pull request
Jun 20, 2024
PR fastapi#5346 seems to have partially done this already, however a lot of references are still outdated in the docs. This commit updates all remainders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Uvicorn link from gitlab to github to reflect current hosting
https://gitlab.com/pgjones/hypercorn/-/commit/65e539a9dc762cb19f4907038fe6d490dac909ff