Ensure skip_defaults doesn't cause extra fields to be serialized
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 243 243
Lines 5696 5698 +2
=====================================
+ Hits 5696 5698 +2
Continue to review full report at Codecov.
|
|
Good catch! 🔍 🕵️♂️ 🚀 Thanks a lot! 🎉 🍰 |
|
Just wonder if line 49 in routing.py shouldn't read: When using a response model that uses field aliases, the validation step following that conversion always fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
skip_defaultsis true, the secure cloned field is not used when serializing the response. This can lead to extra information leaking out if theresponse_modeldiffers in type from the returned model.This pull request fixes this bug, and updates the relevant unit test to check for it.
(The bug was introduced in #422 -- sorry about that!)
I believe this pull request also improves performance in the case where
skip_defaultsisTrue, as the response will now only be validated once in theserialize_responsecall, instead of twice.