8000 ⬆ Upgrade Starlette from 0.19.0 to 0.19.1 by Kludex · Pull Request #4819 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆ Upgrade Starlette from 0.19.0 to 0.19.1 #4819

Merged
merged 26 commits into from
May 10, 2022
Merged

⬆ Upgrade Starlette from 0.19.0 to 0.19.1 #4819

merged 26 commits into from
May 10, 2022

Conversation

Kludex
Copy link
Member
@Kludex Kludex commented Apr 24, 2022

No description provided.

@codecov
Copy link
codecov bot commented Apr 24, 2022 •
edited
Loading

Codecov Report

Merging #4819 (51de254) into master (0696454) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4819   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629
Impacted Files Coverage Δ
fastapi/applications.py 100.00% <100.00%> (ø)
fastapi/exceptions.py 100.00% <100.00%> (ø)
fastapi/routing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0696454...51de254. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit a22f960 at: https://62654b8f42ae7724f206379e--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit f804228 at: https://62654d22edbd572037ea0d4f--fastapi.netlify.app

@github-actions
Copy link
Contributor
github-actions bot commented May 3, 2022

📝 Docs preview for commit 3566f1e at: https://6270c278e65a4a7592cc01f6--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1136a06 at: https://6279d100ba249d2254f741ee--fastapi.netlify.app

@tiangolo tiangolo changed the title Bump starlette from 0.19.0 to 0.19.1 ⬆ Upgrade Starlette from 0.19.0 to 0.19.1 May 10, 2022
tiangolo
tiangolo reviewed May 10, 2022
View reviewed changes
fastapi/routing.py
Comment on lines +481 to +485
routes=routes,
redirect_slashes=redirect_slashes,
default=default, # type: ignore # in Starlette
on_startup=on_startup, # type: ignore # in Starlette
on_shutdown=on_shutdown, # type: ignore # in Starlette
default=default,
on_startup=on_startup,
on_shutdown=on_shutdown,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice to have these better type annotations in Starlette! 🎉

@tiangolo
Copy link
Member

Thanks @Kludex! 🚀 🍰

@tiangolo tiangolo enabled auto-merge (squash) May 10, 2022 02:52
@github-actions
Copy link
Contributor

📝 Docs preview for commit ff2bb15 at: https://6279d3f55ab01a26570b2eae--fastapi.netlify.app

@tiangolo tiangolo merged commit f396912 into fastapi:master May 10, 2022
@Kludex Kludex deleted the bump/starlette-0.19.1 branch May 10, 2022 04:31
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@Kludex @tiangolo @JeanArhancet
⬆ Upgrade Starlette from 0.19.0 to 0.19.1 (fastapi#4819)
e6b4daa 
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kludex @tiangolo
0