8000 Improve testing by Jamim · Pull Request #465 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing #465

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Improve testing #465

merged 2 commits into from
Aug 30, 2019

Conversation

Jamim
Copy link
Contributor
@Jamim Jamim commented Aug 25, 2019

Hello Sebastián,

Classifiers at pyproject.toml says that Python 3.8 is supported already, but there are no tests for this version on Travis CI.
This PR enables tests for Python 3.8-dev and nightly.

Best regards!

Jamim and others added 2 commits August 25, 2019 23:11
@Jamim
Improve testing
abbed32 
Classifiers at pyproject.toml says that Python 3.8 is supported
already, but there are no tests for this version on Travis CI.
These changes enable tests for Python 3.8-dev and nightly.
@tiangolo
✅ Allow Travis failures for 3.8-dev, as Pydantic still allows them
5a211fb
@codecov
Copy link
codecov bot commented Aug 30, 2019

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #465   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         242    242           
  Lines        5677   5762   +85     
=====================================
+ Hits         5677   5762   +85
Impacted Files Coverage Δ
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_duplicate_models_openapi.py 100% <0%> (ø) ⬆️
...test_tutorial/test_path_params/test_tutorial005.py 100% <0%> (ø) ⬆️
tests/test_dependency_overrides.py 100% <0%> (ø) ⬆️
docs/src/bigger_applications/app/routers/items.py 100% <0%> (ø) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77a43b...5a211fb. Read the comment docs.

@codecov
Copy link
codecov bot commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #465    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         242    251     +9     
  Lines        5677   5969   +292     
======================================
+ Hits         5677   5969   +292
Impacted Files Coverage Δ
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_duplicate_models_openapi.py 100% <0%> (ø) ⬆️
...test_tutorial/test_path_params/test_tutorial005.py 100% <0%> (ø) ⬆️
tests/test_dependency_overrides.py 100% <0%> (ø) ⬆️
docs/src/bigger_applications/app/routers/items.py 100% <0%> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77a43b...5a211fb. Read the comment docs.

@tiangolo tiangolo merged commit f24d744 into fastapi:master Aug 30, 2019
@Jamim Jamim deleted the feature/improve-testing branch August 30, 2019 23:35
@tiangolo
Copy link
Member

Thanks @Jamim ! 🎉

I updated it to allow failures in Python 3.8-dev, as Pydantic still allows them. Once Pydantic enforces it I'll update it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jamim @tiangolo
0