8000 media_types of Body params determine media_type of requestBody (Fixes #431) by divums · Pull Request #439 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media_types of Body params determine media_type of requestBody (Fixes #431) #439

Merged
merged 1 commit into from
Aug 30, 2019
Merged

media_types of Body params determine media_type of requestBody (Fixes #431) #439

merged 1 commit into from
Aug 30, 2019

Conversation

divums
Copy link
Contributor
@divums divums commented Aug 15, 2019

If media_type of body parameters matches then pass that to schema field.

Fixes: #431

@codecov
Copy link
codecov bot commented Aug 15, 2019

Codecov Report

Merging #439 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage     100%   99.82%   -0.18%     
==========================================
  Files         240      241       +1     
  Lines        5626     5654      +28     
==========================================
+ Hits         5626     5644      +18     
- Misses          0       10      +10
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100% <100%> (ø) ⬆️
tests/test_request_body_parameters_media_type.py 100% <100%> (ø)
tests/test_union_inherited_body.py 65.51% <0%> (-34.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033bc2a...c5ee650. Read the comment docs.

1 similar comment
@codecov
Copy link
codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #439 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage     100%   99.82%   -0.18%     
==========================================
  Files         240      241       +1     
  Lines        5626     5654      +28     
==========================================
+ Hits         5626     5644      +18     
- Misses          0       10      +10
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100% <100%> (ø) ⬆️
tests/test_request_body_parameters_media_type.py 100% <100%> (ø)
tests/test_union_inherited_body.py 65.51% <0%> (-34.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033bc2a...c5ee650. Read the comment docs.

@tiangolo tiangolo merged commit c581791 into fastapi:master Aug 30, 2019
@tiangolo
Copy link
Member

Awesome! Thanks! 🚀 🌮

@phy25 phy25 mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None 4337 yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI: media_types of Body parameters and requestBody do not match
2 participants
@divums @tiangolo
0