8000 De-duplicate Doks' customized Bootstrap SCSS variables from default ones · Issue #68 · thuliteio/doks-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

De-duplicate Doks' customized Bootstrap SCSS variables from default ones #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
salim-b opened this issue Oct 24, 2023 · 0 comments · Fixed by #86
Closed

De-duplicate Doks' customized Bootstrap SCSS variables from default ones #68

salim-b opened this issue Oct 24, 2023 · 0 comments · Fixed by #86
Assignees
@h-enk
Labels
enhancement New feature or request

Comments

@salim-b
Copy link
Contributor
salim-b commented Oct 24, 2023

Summary

Doks heavily customizes Bootstrap SCSS variables (which is fine, of course). But when developing Doks inital styling, the whole set of Bootstrap variables was basically duplicated (only the !default modifiers were removed).

Ideally, only the SCSS rules that deviate from Bootstrap's defaults should be included in Doks' _variables.scss and _variables-dark.scss.

Bootstrap's default _variables.scss and _variables-dark.scss are already loaded by app.scss, so we can clean up Doks custom variables without breaking the site.

Motivation

Maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-enk h-enk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructures dependencies+ thuliteio/doks-core
2 participants
@h-enk @salim-b
0