8000 let double click on a failing test open the diff · Issue #92 · texttest/texttest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

let double click on a failing test open the diff #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails 8000 .

Already on GitHub? Sign in to your account

Jump to bottom
Open
behrisch opened this issue Nov 7, 2021 · 3 comments
Open

let double click on a failing test open the diff #92

behrisch opened this issue Nov 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@behrisch
Copy link
Collaborator
behrisch commented Nov 7, 2021

It currently only works if you click on the differing file but clicking directly on the test could just open all diffs (or at least the first one?)
@behrisch behrisch added the enhancement New feature or request label Nov 7, 2021
@gjb1002
Copy link
Collaborator
gjb1002 commented Nov 11, 2021

I'm a little bit skeptical about this. All diffs could easily be 20 files and I don't think 20 diff windows would be helpful to anyone. The first in the list might not be the relevant error either. Indeed for "catastrophic failures" - e.g. python stacktrace, generally all you need is the stacktrace in the preview and you don't need diff windows at all.

I think it is better to require an extra click sometimes than to "overautomate" and do things that the user might not want.

@behrisch
Copy link
Collaborator Author

Can we maybe resort to just allowing the double click if there is only one file in the diff? I just find myself trying this regularly.

@gjb1002
Copy link
Collaborator
gjb1002 commented Nov 12, 2021

Yes, ok, I guess that's a reasonable compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behrisch @gjb1002
0