[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native text input box hides the keyboard #2077

Closed
Archenoth opened this issue May 21, 2021 · 4 comments
Closed

Native text input box hides the keyboard #2077

Archenoth opened this issue May 21, 2021 · 4 comments
Labels
bug report

Comments

@Archenoth
Copy link
Contributor

Problem description

When you swipe the extra keys row to get to the native input text box for typing, the soft keyboard hides itself.

In addition, when you tap the terminal, if you tap the text input box again, the keyboard hides and returns really quickly, resizing the terminal twice in the process. (Which can be really noticeable in ncurses programs)

Steps to reproduce

  1. Open a new Termux window with an extra keys row while using a soft keyboard
  2. Swipe the extra keys row to get access to the native input box

And for bonus points, after the above:

  1. Tap the terminal window
  2. Tap the native input box as if you were going to type

GIF showing both issues, first showing a termux window with a keyboard, and watching it disappear both when swiping the extra keys row, and also when tapping the terminal and then the native input box

Expected behavior

Neither situation should hide the keyboard and cause terminal resizes.

Additional information

  • Termux application version: Version 0.113
  • Android OS version: 11
  • Device model: Pixel 5
@ghost
Copy link
ghost commented May 21, 2021

Confirming issue on the latest version (v0.113). Doesn't happen on 0.112.

@ghost ghost added the bug report label May 21, 2021
@agnostic-apollo
Copy link
Member

Thanks for the report. Should be fixed in the next release.

@Archenoth
Copy link
Contributor Author

Nice! Thank youuu~

@agnostic-apollo
Copy link
Member

welcome :)

@agnostic-apollo agnostic-apollo mentioned this issue Jun 5, 2021
Closed
@ghost ghost locked and limited conversation to collaborators Oct 17, 2021
AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this issue Aug 8, 2022
@agnostic-apollo
Do not close soft keyboard when toolbar text input view is focused on
9ff8f94 
The TerminalToolbarViewPager EditText was requesting focus when it was selected. This called the TerminalView.onFocusChange() event with hasFocus=false, which closed the soft keyboard. Now soft keyboard will only be closed if both of them don't have focus.

Fixes termux#2077
shrihankp pushed a commit to reisxd/termux-app that referenced this issue Oct 20, 2022
@agnostic-apollo
Do not close soft keyboard when toolbar text input view is focused on
e8c17d5 
The TerminalToolbarViewPager EditText was requesting focus when it was selected. This called the TerminalView.onFocusChange() event with hasFocus=false, which closed the soft keyboard. Now soft keyboard will only be closed if both of them don't have focus.

Fixes termux#2077
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Archenoth @agnostic-apollo