8000 NPM module is missing three as a peer dependency · Issue #4 · tentone/potree-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NPM module is missing three as a peer dependency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ekatzenstein opened this issue Apr 21, 2019 · 2 comments
Open

NPM module is missing three as a peer dependency #4

ekatzenstein opened this issue Apr 21, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ekatzenstein
Copy link

An imported module cannot rely on a globally imported THREE
@tentone
Copy link
Owner
tentone commented May 2, 2019

Hi

I might add a second build without the hardcoded globally imported THREE variable, having it instead as a peer dependency.

Thanks a lot for reporting.

@tentone tentone added the enhancement New feature or request label May 2, 2019
@tsari-lidar-perception
Copy link

Hi author, I am currently working on a project using react. I have installed potree-core through npm. However it returns the undefined THREE error. Can you give a simple example using potree-core in react? Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ekatzenstein @tentone @tsari-lidar-perception
0