Make TraceID and SpanID Field Names Configurable in OpenTelemetry Integration #1734
Conversation
|
imane el-aiboud seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
@Quinn-With-Two-Ns - thoughts? We have several fields we add to logger in this SDK that we don't allow customizing of the names of. But I don't have any strong objections.
| // TraceIDFieldName is the name of the field used to represent the Trace ID | ||
| // If empty, a default name will be used. | ||
| TraceIDFieldName string | ||
|
|
||
| // SpanIDFieldName is the name of the field used to represent the Span ID | ||
| // If empty, a default name will be used. | ||
| SpanIDFieldName string |
There was a problem hiding this comment.
| // TraceIDFieldName is the name of the field used to represent the Trace ID | |
| // If empty, a default name will be used. | |
| TraceIDFieldName string | |
| // SpanIDFieldName is the name of the field used to represent the Span ID | |
| // If empty, a default name will be used. | |
| SpanIDFieldName string | |
| // TraceIDLoggerFieldName is the name of the field used to represent the Trace ID in logger. | |
| // If empty, a default name will be used. | |
| TraceIDLoggerFieldName string | |
| // SpanIDLoggerFieldName is the name of the field used to represent the Span ID in logger. | |
| // If empty, a default name will be used. | |
| SpanIDLoggerFieldName string |
Not clear this is only for logger and nothing else
|
In general to rename attributes we recommend doing replacement at the logger level. How depends on your logger, but here is an example for the standard library logger. |
Thank you for the suggestion! I agree, it’s a great idea. I’ll make the changes at the logger level as recommended and close the PR. Thanks for the helpful link! |
|
Closing this PR as the changes will be implemented at the logger level following the recommended approach. Thanks again for the feedback! |
This PR updates the Temporal Go SDK to make TraceID and SpanID field names configurable in the OpenTelemetry integration. By default, the fields remain TraceID and SpanID, ensuring backward compatibility. This change resolves inconsistencies when integrating Temporal logs with systems using different conventions.
Please review and let me know if additional changes or tests are needed.