feat: remove borders from thread-full and suggestions #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
The diff primarily focuses on removing borders and modifying padding for UI components. Minor points include a potential unintended removal of the shadow-sm class and possible redundancy between bg-white and bg-background in MessageThreadFull. The button padding change in MessageSuggestions should also be verified against design consistency.
Additional notes (2)
- Readability |
cli/src/registry/message-thread-full/message-thread-full.tsx:60-60
The removal of the border classes is in line with the commit message, but note that the outer container inMessageThreadFullalso had theshadow-smclass removed along with bothbg-whiteandbg-backgroundbeing applied. This might be intentional, but it could lead to unexpected styling conflicts. Please verify that these changes are deliberate and consistent with your overall design guidelines.
Reply with "@CharlieHelps yes please" if you'd like me to add a commit with a suggestion for clarifying these styles.
- Readability |
cli/src/registry/message-suggestions/message-suggestions.tsx:164-164
The vertical padding for suggestion buttons was increased frompy-1topy-2, which might affect the overall button sizing. Ensure that this change fits within your design system and provides a consistent user experience.
Reply with "@CharlieHelps yes please" if you'd like me to add a commit with a suggestion to adjust or document this change.
Summary of changes
Summary of Changes
-
MessageSuggestions Component
- Removed the top border classes (
border-t border-gray-200) from the container div. - Adjusted the vertical padding of the suggestion buttons from
py-1topy-2for a larger clickable area.
- Removed the top border classes (
-
MessageThreadFull Component
- Removed the border classes (
border border-gray-200) and theshadow-smclass from the outer container. - Removed border classes from both the header and footer sections.
- Removed the border classes (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.