10000 feat(cli): update message-input component style by MichaelMilstead · Pull Request #306 · tambo-ai/tambo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cli): update message-input component style #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

MichaelMilstead
Copy link
Collaborator

Updates style of installable message-input component

@charliecreates charliecreates bot requested a review from CharlieHelps April 9, 2025 18:51
Copy link
vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
showcase ⬜️ Skipped (Inspect) Apr 9, 2025 6:51pm

@github-actions github-actions bot added the feat label Apr 9, 2025
Copy link
@charliecreates charliecreates bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff introduces a shift from an input to a textarea with updated styling and key event handling. The changes in key submission behavior and the removal of autoFocus might alter the user experience, so please verify that these modifications are intentional.

Additional notes (2)
  • Readability | cli/src/registry/message-input/message-input.tsx:111-115
    The keydown event handler now submits the message on Enter (without Shift) rather than on Ctrl/⌘ + Enter as in the previous implementation. This change affects the UX for inserting newlines in the textarea. Please confirm that this new behavior is intentional.

  • Readability | cli/src/registry/message-input/message-input.tsx:137-140
    The autoFocus attribute that was present on the previous input element has been removed in the new textarea implementation. This might impact usability on initial component render if autofocus was intended.

Summary of changes

Summary of Changes

  • Component Type Update: The component has been updated to use a <textarea> instead of an <input>, and the corresponding types (HTMLTextAreaElement) and refs have been updated.
  • Styling & Layout: The layout now features a flex column container with updated Tailwind CSS classes, and the send button now uses an ArrowUp icon with a tooltip instead of the previous text-based button.
  • Event Handler Changes: The keydown handler now submits the message when pressing Enter (without Shift), as opposed to the previous Ctrl/⌘ + Enter behavior.
  • Minor Modifications: The autoFocus attribute on the input has been removed and the placeholder text has been changed to "What do you want to do?".

@charliecreates charliecreates bot removed the request for review from CharlieHelps April 9, 2025 18:52
@MichaelMilstead MichaelMilstead merged commit 0454392 into main Apr 9, 2025
6 checks passed
@MichaelMilstead MichaelMilstead deleted the milst/message-input-style branch April 9, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0