fix: Don't throw error if TamboProvider used outside browser #271
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
While the change meets the goal of avoiding server-side errors by logging instead of throwing, allowing the remainder of the component to render in non-browser environments may lead to unintended side effects. A conditional early return could improve the robustness and maintainability of the code.
Summary of changes
Summary
- Replaced the thrown error with a
console.errorlog whenwindowis undefined. - Updated the inline comment from 'explode if we're not in a browser' to 'Should only be used in browser'.
| // Should only be used in browser | ||
| if (typeof window === "undefined") { | ||
| throw new Error("TamboProvider must be used within a browser"); | ||
| console.error("TamboProvider must be used within a browser"); |
There was a problem hiding this comment.
The update successfully avoids crashing on the server by logging the error instead of throwing. However, the component continues rendering even when window is undefined, which might lead to unexpected behavior if subsequent browser-specific APIs are used. Consider returning null immediately after logging the error to safely bypass rendering in non-browser contexts. Reply with "@CharlieHelps yes please" if you'd like me to add a comm
8000
it with this suggestion.
if (typeof window === 'undefined') {
console.error('TamboProvider must be used within a browser');
return null;
}
Changes the error throw to an error log since in NextJS the provider is rendered once on server-side.