8000 fix: expose fetch param from switchthread by MichaelMilstead · Pull Request #170 · tambo-ai/tambo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: expose fetch param from switchthread #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2025
Merged

fix: expose fetch param from switchthread #170

merged 2 commits into from
Mar 21, 2025

Conversation

MichaelMilstead
Copy link
Collaborator
@MichaelMilstead MichaelMilstead commented Mar 21, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Enhanced thread switching with an added option to control whether the latest thread content is fetched immediately, allowing users more flexible and responsive navigation.

@github-actions github-actions bot added the fix label Mar 21, 2025
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Mar 21, 2025 •
edited
Loading

Im 8000 portant

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The change updates the switchCurrentThread method by modifying its signature in the TamboThreadContextProps interface to accept an optional fetch parameter. The implementation in the TamboThreadProvider component now conditionally fetches thread data based on the value of this new parameter.

Changes

File Change Summary
react-sdk/src/providers/.../tambo-thread-provider.tsx Updated switchCurrentThread method signature to (threadId: string, fetch?: boolean) => void and adjusted its implementation for conditional fetching.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Provider as TamboThreadProvider
    participant DataService as ThreadDataService

    Caller->>Provider: switchCurrentThread(threadId, fetch)
    alt fetch is true
        Provider->>DataService: Fetch thread data for threadId
        DataService-->>Provider: Thread data retrieved
    else fetch is false
        Provider-->>Caller: No fetch performed
    end
    Provider-->>Caller: Updated thread state
Loading

Possibly related PRs

Poem

I'm a rabbit with a code hop,
Switching threads with a brand new pop,
An extra fetch to guide the way,
In our thread dance night and day,
Keep on hopping—no bug can make me stop!
🐇✨

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MichaelMilstead MichaelMilstead merged commit 83f41fe into main Mar 21, 2025
5 checks passed
@MichaelMilstead MichaelMilstead deleted the milst/switch-thread-param branch March 21, 2025 20:13
@alecf alecf mentioned this pull request Mar 21, 2025
Merged
This was referenced Mar 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaelMilstead
0