8000 fix: include tool_call_id in response, for full round-trip by alecf · Pull Request #143 · tambo-ai/tambo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: include tool_call_id in response, for full round-trip #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: include tool_call_id in response, for full round-trip #143

merged 1 commit into from
Mar 17, 2025

Conversation

alecf
Copy link
Contributor
@alecf alecf commented Mar 17, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Improved message tracking by integrating an additional property that captures tool call context, ensuring enhanced traceability during message processing.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Mar 17, 2025 •
edited
Loading

Walkthrough

The changes update the TamboThreadProvider component by adding a new property, tool_call_id, to the messageToAppend object within the handleAdvanceStream and sendThreadMessage functions. This property is extracted from the response data (responseMessageDto in both the chunk and advanceResponse) to enhance tracking of tool calls associated with message processing. No existing functionality has been removed; the change solely extends the data structure used in handling messages.

Changes

File Path Change Summary
react-sdk/src/.../tambo-thread-provider.tsx Added extraction and inclusion of tool_call_id in messageToAppend in both handleAdvanceStream and sendThreadMessage functions.

Sequence Diagram(s)

sequenceDiagram
    participant Provider as TamboThreadProvider
    participant Server as Response Source
    participant Queue as Message Queue

    Provider->>Server: Request/process message chunk/advanceResponse
    Server-->>Provider: Return responseMessageDto (includes tool_call_id)
    Provider->>Queue: Append messageToAppend with tool_call_id
Loading

Poem

I'm a hopping coder, a rabbit so keen,
Adding tool_call_ids where they've never been seen.
With every new message and every new stream,
I nibble on logic and code with a gleam.
Hoppy and clever, I bound through the scene!
🐇🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c6377d and c28c654.

📒 Files selected for processing (1)
  • react-sdk/src/providers/tambo-thread-provider.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
react-sdk/src/providers/tambo-thread-provider.tsx (2)

368-368: Adding tool_call_id to track tool call responses in streaming mode - good addition!

This change properly propagates the tool_call_id from the response message to the tool call response parameters in the streaming code path. This ensures a proper association between tool call requests and their corresponding responses, enabling full round-trip tracking.

520-520: Good implementation of tool_call_id in non-streaming path

This parallel change maintains consistency with the streaming implementation, ensuring tool_call_id is included in the tool response parameters regardless of whether streaming is used. This consistent approach will help with debugging, tracing, and properly associating tool calls with their responses.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the fix label Mar 17, 2025
@alecf alecf merged commit deb96ab into main Mar 17, 2025
6 checks passed
@alecf alecf deleted the alecf/bump-react-tool-id branch March 17, 2025 21:16
@alecf alecf mentioned this pull request Mar 17, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alecf
0