feat: add template selection for create-app command #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
The interactive prompt default value isn’t one of the valid template keys, causing an undefined selection. Errors thrown during template validation occur outside your catch block, leading to unhandled exceptions. The manual .git folder removal duplicates existing helper logic instead of reusing safeRemoveGitFolder.
Additional notes (1)
- Readability |
cli/src/commands/create-app.ts:190-190
You're duplicating.gitfolder validation and removal logic instead of using the existingsafeRemoveGitFolderhelper declared above, leading to scattered validation code. Consolidate by calling the helper.
Summary of changes
Summary of Changes
-
CLI Updates
- Added a
--template, -t <name>flag toCLIFlagsincli/src/cli.ts. - Updated the usage, commands, and examples sections to include the new
create-apptemplate flag. - Passed the
templateflag through tohandleCreateAppinvocation.
- Added a
-
Template Selection in
create-app- Imported
inquirerand defined a newTemplateinterface andtemplatesmap incli/src/commands/create-app.ts. - Introduced non-interactive (via
--template) and interactive (viainquirer.prompt) flows to select a project template. - Updated the
git clonecommand and spinners to use the selected template’s repository URL. - Enhanced post-clone messages to report the chosen template.
- Imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.