8000 Honor Content-Type charset · Issue #704 · typhoeus/typhoeus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Honor Content-Type charset #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on Gi 8000 tHub? Sign in to your account

Jump to bottom
Open
semaperepelitsa opened this issue Nov 11, 2022 · 3 comments
Open

Honor Content-Type charset #704

semaperepelitsa opened this issue Nov 11, 2022 · 3 comments

Comments

@semaperepelitsa
Copy link

Original issue: #580

The default Faraday adapter sets body encoding based on Content-Type header: lostisland/faraday-net_http#13

Would you be willing to accept a PR implementing the same for Typhoeus-Faraday adapter?

Since Typhoeus itself don't parse headers, I think the adapter is the most appropriate place to implement this.
@semaperepelitsa
Copy link
Author
semaperepelitsa commented Nov 15, 2022 •
edited
Loading

Since Typhoeus itself don't parse headers, I think the adapter is the most appropriate place to implement this.

Correction: both Typhoeus and Faraday parse response headers, so we can implement in either.

@semaperepelitsa
Copy link
Author

cc @dleavitt

@dleavitt
Copy link

@semaperepelitsa I'd be happy to look into implementing analogous functionality (or reviewing a PR that does) on dleavitt/faraday-typhoeus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dleavitt @semaperepelitsa
0