Replies: 1 comment 4 replies
-
|
Can you please add more details? This is a little vague. Specifically, when you say "is a type", do you mean in KSP's types or in how KotlinPoet's KSP interop resolves that somewhere? A code snippet would help. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, so the way KSP handles interface Greeter {
fun hello(vararg names: String)
}When analysed with KSP1, the resolved type ( Nothing related to KotlinPoet (or its KSP interop) so far. But when generating code now with KotlinPoet based on the resolved type ( val namesParameter = ksFunctionDeclaration.parameters.first()
FunSpec.builder("hello")
.addModifiers(KModifier.OVERRIDE)
.addParameter(ParameterSpec.builder(
name = it.name!!.asString(),
type = it.type.toTypeName(),
modifiers = arrayOf(KModifier.VARARG)
).build()
)With KSP1 it will generate the correct code: override fun hello(vararg names: String){}With KSP2 it will generate different code: override fun hello(vararg names: Array<out String>){}So with KSP2 I have to "unwrap" the This leads me to my original question: But as KSP2 will be the future and handles it differently: Will the handling of KotlinPoet stay as it is (i.e. non-array wrapped type), or do you have any plans to also change the way of defining Example (pure KotlinPoet): val array = ClassName("kotlin", "Array")
val string = String::class.asClassName()
val producerArrayOfStrings = array.parameterizedBy(WildcardTypeName.producerOf(string))
FunSpec.builder("hello")
.addModifiers(KModifier.OVERRIDE)
// current way (in sync with KSP1)
.addParameter("names", string, KModifier.VARARG)
// vs "KSP2 way"
.addParameter("names", producerArrayOfStrings, KModifier.VARARG)
.build() |
Beta Was this translation helpful? Give feedback.
-
|
I prefer the "KSP 2" way. We can't change existing behavior, though. Will have to change in 3.x which we're kicking off work on soon. |
Beta Was this translation helpful? Give feedback.
-
|
@JakeWharton Me personally I like the current way of KotlinPoet, as it is simpler and more natural, as you also would write I created an issue in the KSP project (google/ksp#2379) and it currently seems this change may not have been intended. If KSP2 fixes this and keeps returning |
Beta Was this translation helpful? Give feedback.
-
|
We don't necessarily model precisely what you write, though. For a constructor property you have to generate a constructor parameter, class property, and initializer and then we match that the syntax can be made more efficient by writing out a constructor property. This is similar, the type is always |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
With KSP1, a function
fun main(varargs args: String)would have a parameter with the typeString.With KSP2, that parameter is of type
Array<out String>.Currenlty the way of kotlinpoet matches with the approach of KSP1. Will this remain as is?
Beta Was this translation helpful? Give feedback.
All reactions