Support variables with dot in python templater #5872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessed using dot notation in python format strings
Coverage Results ✅ |
alanmcruickshank
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Initially I didn't like this hack, but I think I'm warming to it.
It's definitely a hack, but it's a convenient one, and I think a pragmatic one. Good work 👍 .
I've got a couple of notes on how to make this clearer and easier for the user to understand. Likewise, making it clear when it fails so that the user knows what's happening.
|
Oh and on the merge conflict, I split out a lot of the very large config files as part of #6052 . The file that your edits should now go in is |
Co-authored-by: Alan Cruickshank <alan+git@designingoverload.com>
…lfluff into python-templater-variables-dot-notation # Conflicts: # docs/source/configuration.rst # src/sqlfluff/core/templaters/python.py
alanmcruickshank
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
fixes #5871
Adds support for python format strings containing variables with dot notation by temporarily converting these variables into a dictionary lookup using the fixed context key
sqlfluff.I believe this is the simplest, most straightforward solution to this issue. Adding this "magic" context key into configuration might not be intuitive at first, but I think it can be easily understood through the documentation.
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.