8000 Console Warnings When Using React 16.9 · Issue #181 · spotify/reactochart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Console Warnings When Using React 16.9 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub
8000

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ekh64 opened this issue Sep 25, 2019 · 0 comments · Fixed by #234
Closed

Console Warnings When Using React 16.9 #181

ekh64 opened this issue Sep 25, 2019 · 0 comments · Fixed by #234
Labels
infra

Comments

@ekh64
Copy link
Collaborator
ekh64 commented Sep 25, 2019

With the release of React 16.9, they added warnings for soon to be deprecated lifecycle methods. Reactochart leverages a couple of the methods and causes a lot of console warnings.

A fast fix is to rename the functions UNSAFE_<lifecyclemethod>, a better, but more time consuming fix is to refactor the code to use deriveStateFromProps and componentDidX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated Lifecycle hooks spotify/reactochart
2 participants
@ekh64 @krissalvador27
0