8000 `make release` target · Issue #761 · spacetx/starfish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make release target #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 10 tasks
joshmoore opened this issue Nov 1, 2018 · 8 comments · Fixed by #1059
Closed
8000 5 of 10 tasks

make release target #761

joshmoore opened this issue Nov 1, 2018 · 8 comments · Fixed by #1059

Comments

@joshmoore
Copy link
Member
joshmoore commented Nov 1, 2018 •
edited
Loading

see: #709 (comment)

Potential sequence:

  • run extended check_requirements to sync conda
  • bump version number
  • build sdist, install, and test with the installation:
  • commit, tag, push tag
  • build package and push to pypi
  • build docker and push to hub
  • generate and push commit to bioconda-recipes (and potentially open a PR) (happens automatically now on tagging)
  • add .dev to version number, commit, and push to master (not needed with versioneer)

Similar checklist for comparison:

Other things to consider:
@joshmoore joshmoore mentioned this issue Nov 1, 2018
Merged
@joshmoore joshmoore mentioned this issue Dec 10, 2018
Closed
@ambrosejcarr
Copy link
Member

Hey @joshmoore we've received some feedback that it has been hard for external developers to come back to starfish after a few weeks have elapsed and figure out what's happened. We're thinking about initiating to a release cycle (maybe bi-weekly?) to help mitigate this.

Would you be interested in creating this make target? If you build it, we'll commit to using it every weeks, and having clear changelogs :-)

@joshmoore
Copy link
Member Author

Investigating. I'll post some thoughts ASAP.

@ttung ttung mentioned this issue Feb 28, 2019
Merged
@joshmoore
Copy link
Member Author

Ok. I have something that's mostly working based on pbr:

If there are any preliminary objections to that, now would be a good time to express them. The general release process would be:

git tag -s -m "..." 0.0.35 HEAD  # No need to edit a file with the version
make release-prep   # Fails if no tag is present; runs quickly & installs starfish
make release-verify # Runs slowly, needs to be manually reviewed
make release-upload # Prints commands that all need to run successfully, e.g.

  # Please execute the following steps
  git push origin
  docker push spacetx/starfish:latest
  docker push spacetx/starfish:0.0.35
  twine upload dist/starfish-0.0.35.tar.gz

If there are any issues, the commands need to be rolled back last to front:

  • delete from docker
  • delete tag from github
  • delete tag locally
  • make clean
  • startover or get a ☕

@joshmoore
Copy link
Member Author
joshmoore commented Mar 3, 2019 •
edited
Loading

There are some who have moved away from pbr: https://github.com/pyscaffold/pyscaffold/issues/116

other options for the version calculation:

This was referenced Mar 3, 2019
Merged
Closed
@ambrosejcarr
Copy link
Member

If there are any preliminary objections to that, now would be a good time to express them. The general release process would be:

Looks like you provided your own objection 😆

No problems here, very interested to see what you come up with!

@joshmoore
Copy link
Member Author

Heh. It did "just work" (TM) for starfish, so I wouldn't be opposed to rolling back to it and dropping versioneer. Probably need a discussion around all of this.

@ttung
Copy link
Collaborator
ttung commented Mar 7, 2019

I just read this (I suck). I understand #1059 much better now. :)

@joshmoore
Copy link
Member Author

I understand #1059 much better now. :)

🤣 (I looked for a place to put this content since it will be useful but didn't find anything definitive. Preferences?

  • README.md
  • RELEASE.md
  • docs/source/usage/...
  • docs/source/maintainers/...
  • docs/source/?
  • Makefile
  • ...
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make release joshmoore/starfish
3 participants
@joshmoore @ttung @ambrosejcarr
0