8000 Allow pathlib Path/PosixPath as model_spec · Issue #98 · sot/xija · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow pathlib Path/PosixPath as model_spec #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeanconn opened this issue Oct 12, 2020 · 3 comments · Fixed by #99
Closed

Allow pathlib Path/PosixPath as model_spec #98

jeanconn opened this issue Oct 12, 2020 · 3 comments · Fixed by #99
Labels
enhancement

Comments

@jeanconn
Copy link
Contributor

It looks like:

xija/xija/model.py

Line 108 in 64b8108

model_spec = json.load(open(model_spec, 'r'))

only allows model_spec files as string filenames.
@taldcroft
Copy link
Member

The problem is actually here:

xija/xija/model.py

Line 107 in 64b8108

if isinstance(model_spec, six.string_types):

@jeanconn
Copy link
Contributor Author
jeanconn commented Oct 12, 2020 •
edited
Loading

Right, I saw that and understood the reason why, but should have linked the line up for clarity.

@jeanconn
Copy link
Contributor Author

And then a question about if six should be removed, if this should be handled with a try-to-read or some such, or if the user should just do what I did in my dev perigee_health_plots and str(PosixPath).

@taldcroft taldcroft mentioned this issue Oct 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow model_spec to be provided as Path sot/xija
2 participants
@taldcroft @jeanconn
0