Description
This is related to PR #81 and with a MacOS device.
On this line:
https://github.com/soloterm/solo/blob/main/src/Console/Commands/Solo.php#L41
the screen -v
command on Mac returns the exit code 1, ->isSuccessful
is only checking for exit code === 0 so it's filling up the error log with the "unable to determine screen version".
Separately, my screen version is 4.x, not 5.x - if we're expecting users to bump versions to 5.x manually (as mine is stock latest MacOS) and otherwise send an error log then I'd propose adding something to the readme to that effect. OR, reduce the compatibility check to < 4.0.0?
Also, given this isn't actually an error, would a Log::warn
or even Log::info
make more sense here?
Happy to add a PR if I can get some thoughts on the above?