8000 Check Screen Version fails on MacOS · Issue #87 · soloterm/solo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Check Screen Version fails on MacOS #87
Open
@williamjulianvicary

Description

@williamjulianvicary

This is related to PR #81 and with a MacOS device.

On this line:
https://github.com/soloterm/solo/blob/main/src/Console/Commands/Solo.php#L41

the screen -v command on Mac returns the exit code 1, ->isSuccessful is only checking for exit code === 0 so it's filling up the error log with the "unable to determine screen version".

Separately, my screen version is 4.x, not 5.x - if we're expecting users to bump versions to 5.x manually (as mine is stock latest MacOS) and otherwise send an error log then I'd propose adding something to the readme to that effect. OR, reduce the compatibility check to < 4.0.0?

Also, given this isn't actually an error, would a Log::warn or even Log::info make more sense here?

Happy to add a PR if I can get some thoughts on the above?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    < 32F9 /div>

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0