Control over minimum coverage + better error messages #154
Comments
|
Roughly like #155 (whipped up in 10 mins, so just illustrating) |
|
Closed by #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Is your feature request related to a problem? Please describe.
Minimum metagene coverage is essentially hard-coded, since a default value is set here, and no interface to that value is provided when calling the function in places like this.
The result is that no reads are selected, and errors appear like:
That doesn't really describe the issue- the problem is that no reads passed the coverage threshold.
This also prevents operation in relatively low read counts, which might make sense scientifically, but makes the module hard to use in test scenarios (where scientific validity is not required).
Describe the solution you'd like
Would you be amenable to a detect-orfs CLI parameter which controls this value? Happy to make a PR.
There should also be an error triggered when all reads are removed in the coverage filter, to make it clear that periodicity is not the problem.
Additional context
Attempting to include ribotricer in the nf-core riboseq workflow.
The text was updated successfully, but these errors were encountered: