Dropping dependency on golang.org/x/crypto #928
Comments
|
I like this idea; I opened a PR. |
|
Unfortunately, the implementation is os-dependent and it’d be quite many files to bring over to get rid of ssh/terminal. I suggest leaving it as is for now. |
|
8 files to bring over. Password-reading related stuff can be removed. golang/go#31044 got reference for golang/go#13104, but honestly, it does not look very promising short term. |
|
Actually... there is a whole bunch of file in logrus starting with terminal_*, we can try to copy these functions there. |
|
I'd rather not, it would be hard to keep up with updates |
|
There are no updates since ... 2011 and 2015 |
This was referenced Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This library is pulled for only one check - to see if output is a terminal or not.
Would it be possible just to inline one used function from it? This would allow us (and all people who pulls it in) to drop the dependency on it as well. The import with "crypto" in it triggers additional attention from our legal department, and we have to explain that it does not have anything "cryptographic" in it - just a check for is it a terminal or not.
Ideally,
ssh/terminalshould be not under crypto , but I will try to ping golang folks about it directly.The text was updated successfully, but these errors were encountered: